steeze-ui / icons

Effortless Icon Packs & Components for Svelte, React, Vue and more..
MIT License
178 stars 15 forks source link

Action #28

Open edde746 opened 1 year ago

edde746 commented 1 year ago

Would be great to have the latest updates of the icon packs, some (especially lucide) are quite outdated at this point. Perhaps even making an Actions job to do this automatically?

JustinVoitel commented 1 year ago

@edde746 yea such a job would be pretty nice to have ^^ Do you have any experience implementing such a Action ?

It would probably just need to parse the current package version from the package.json and check if there is any new version on npm and if so run npm i && npm publish, update changelog and push to github ?

JustinVoitel commented 1 year ago

@edde746 can you test @steeze-ui/lucide-icons@1.1.0 if all is working ?

edde746 commented 1 year ago

@edde746 can you test @steeze-ui/lucide-icons@1.1.0 if all is working ?

Yep, works perfectly.

JustinVoitel commented 6 months ago

@edde746 Regarding the updated npm version of all @steeze-ui/* packages:

What do you think should we

A: inherit the version of the source package, which would be easily implementable via update.py. e.g simple-icons getting updated from version 11.9.0 to 11.11.0 so the @steeze-ui/simple-icons package will be updated from 1.7.1 to 11.11.0. Only Problem would be when we want to manually push a new version (e.g a fix to something) or B: go by our own versioning (as it is right now) which will only get patch bumped every time the version of the source package changes ? e.g simple-icons getting updated from version 11.9.0 to 11.11.0 so the @steeze-ui/simple-icons package will be updated from 1.7.1 to 1.7.2. No Problem with manual updates

edde746 commented 6 months ago

I think B is the only option because of both the manual update issue as you mentioned and some packages not having source packages which would create an inconsistency where both A and B would be used.

JustinVoitel commented 6 months ago

I also tend to B. Will try to get the action working in the next couple of days 👍