search

steezeburger / wikipedia-browser

browse wikipedia a la andy matuschak's evergreen notes
https://steezeburger.com/wikipedia-browser/
Apache License 2.0
25 stars 1 forks source link

user should be able to open images #6

Closed steezeburger closed 2 months ago

vr-varad commented 2 months ago

hey @steezeburger can i give it a shot?

steezeburger commented 2 months ago

@vr-varad that would be great! I am going to refactor the app architect, but I don't think that would affect this work. Feel free to fork this repo and open a pull request!

steezeburger commented 2 months ago

I've reorganized the app a little bit here https://github.com/steezeburger/wikipedia-browser/pull/7

For this issue, you'll probably need to change how handleLinkClick works here https://github.com/steezeburger/wikipedia-browser/blob/main/web/src/components/WikipediaBrowser/WikipediaBrowser.tsx#L54

Also, the work done for this issue will likely be similar to https://github.com/steezeburger/wikipedia-browser/issues/3. You might be able to fix both these.

vr-varad commented 2 months ago

I was able to get the image but currently, I am working on why the main page goes to http://localhost:3000/wiki/File:something.jpg