Models not showing since VSCode 2020 June update

Degubi commented 4 years ago

Bug description: Models not showing up, only an empty scene is displayed (both in 'Viewer' and 'Editor' modes) Steps to reproduce: Update to VSCode 2020 June (v1_47) The format of the model on the images is 'obj'

Using 'v1_46' (May update) may

Using 'v1_47' (June update) june

kangxue commented 4 years ago

VSCode 2020 J

I have the same issue

Josverl commented 4 years ago

samesame , are you using native binding? then the upgrade probably caused your bindings to mismatch

Degubi commented 4 years ago

So looking for errors I found this one that may be related to this issue: webviewElement.ts:160 [Embedded Page] Access to XMLHttpRequest at 'vscode-resource:/c%3A/Users/User/Desktop/modelFolder/model.obj' from origin 'vscode-webview://29619235-bf9d-499e-875a-29ec83297b0d' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: http, vscode-webview-resource, data, chrome, vscode-webview, https.

Edit: Maybe related issue from vsCode repo: https://github.com/microsoft/vscode/issues/102959

Quote from linked issue: Last iteration, we removed support for vscode-resource urls in favor of requiring extensions call asWebviewUri. While webviews attempt to automatically rewrite vscode-resource urls, it looks like we don't get this right in all cases. Using asWebviewUri is the proper fix and it also make it so your extension's webview just works VS Code is run in a browser.

Degubi commented 4 years ago

Made some changes regarding path handling, see #12 Someone should test this, it was working for me locally

anton-matosov commented 4 years ago

Fix resolves rendering issue for

Version: 1.48.0 Commit: db40434f562994116e5b21c24015a2e40b2504e6 Date: 2020-08-13T07:40:55.768Z Electron: 7.3.2 Chrome: 78.0.3904.130 Node.js: 12.8.1 V8: 7.8.279.23-electron.0 OS: Linux x64 5.4.0-42-generic

stef-levesque / vscode-3dviewer

Models not showing since VSCode 2020 June update #11