search

stef-levesque / vscode-3dviewer

Preview 3D meshes in VSCode
MIT License
96 stars 20 forks source link

Fix path handling in provider files #12

Closed Degubi closed 4 years ago

Degubi commented 4 years ago

Fix for an error created by the June 2020 update of VsCode that stopped models displaying in viewer & editor. See #11. Screenshots after applying changes (in v1.47.3):

Jegyzet 2020-07-31 184012 Jegyzet 2020-07-31 152522

Fixes #11

anton-matosov commented 4 years ago

Tried out the branch, it fixes rendering for me in the most recent vscode to date

anton-matosov commented 4 years ago

I have created a release with prebuilt binary in my fork of the fix https://github.com/anton-matosov/vscode-3dviewer/releases/tag/0.2.1

Degubi commented 4 years ago

@stef-levesque could you take a look at this, please?

stef-levesque commented 4 years ago

Thanks @anton-matosov I'll push a new version on the marketplace

anton-matosov commented 3 years ago

Verified the marketplace version 0.2.2 and it renders STL files correctly