search

stef-levesque / vscode-autohotkey

AutoHotkey language support for VS Code
MIT License
96 stars 22 forks source link

Change to Syntax parser #31

Closed helsmy closed 3 years ago

helsmy commented 3 years ago

A basic recursive descent parser is done and ready for providing functions to language server. A massive step of this extension. I hope everyone will happy to see it 😄

helsmy commented 3 years ago

sorroy for bothering I just miss click 😢 .

mark-wiemer commented 3 years ago

FYI, this repo has not merged code since 2018. And note that restoring the branch does not re-open the PR. You can open a PR on my fork of the project if you're interested, it has 10,000+ downloads on VS Code. However, I will say 20,000+ lines of code would take multiple weeks to review. There is good space in my codebase for automated tests that would make reviews much easier.

helsmy commented 3 years ago

FYI, this repo has not merged code since 2018. And note that restoring the branch does not re-open the PR. You can open a PR on my fork of the project if you're interested, it has 10,000+ downloads on VS Code. However, I will say 20,000+ lines of code would take multiple weeks to review. There is good space in my codebase for automated tests that would make reviews much easier.

Oh, thanks for suggestion. I just fork this as a start point of my simple extension. And I am not very fammiliar to github. I was misleaded by the big green button "pull requset" when merge my own branch.