search

stef-levesque / vscode-perforce

Perforce basic commands for Visual Studio Code
MIT License
74 stars 103 forks source link

Performance issues on large perforce instances #154

Open gavinwill opened 5 years ago

gavinwill commented 5 years ago

Hi.

Apologies for not having full details to provide but wanted to get this issue logged promptly. We have seen this plugin make millions of calls to perforce within a couple of days from a single user along with 1000's of concurrent connections. I am trying to obtain debug logs (i have perforce logs but not client logs) from the user but the user is currently remote. It also seems to not dispose of these connections resulting in Idle connections which can result in port exhaustion.

I will reply back with more information as soon as i have gathered it.

gavinwill commented 5 years ago

I have since looked through your project and noticed the following :

"title": "VS Code Perforce Configuration", "properties": { "perforce.bottleneck.maxConcurrent": { "scope": "application", "type": "number", "description": "How many jobs can be executing at the same time", "minimum": 0, "default": null },

it would be a lot nicer if the multiple commands can get bundled into one connection / call to the Perforce server as dictated by Perforce's guide - https://www.perforce.com/manuals/v15.1/p4sag/chapter.performance.html Also by using p4 as a wrapper we cant identify this easily from p4.prog. Having a default p4.prog to identify the calls are coming from this plugin would be great.