Add Swarm link to annotations

stef-levesque / vscode-perforce

Perforce basic commands for Visual Studio Code

MIT License

74 stars 103 forks source link

Add Swarm link to annotations #160

Closed howardcvalve closed 5 years ago

howardcvalve commented 5 years ago

Adds a config option swarmHost to specify as the hostname to link to
If configured, allows clicking on a annotation hover to go to that change in Swarm.

stef-levesque commented 5 years ago

This is quite useful, thanks !

A few comments:

Should we add the protocol to the swarm host ? (http://...)
Maybe add the link on its own line and text ? (Open Changelist in Swarm)

I can also accept the PR as-is and look at it later on.

howardcvalve commented 5 years ago

Added the protocol to the config value.

I think it's fine to leave the link as-is and have been using it for a while that way, but can adjust in response to user feedback.

howardcvalve commented 5 years ago

Hi,

Do you have a timeframe for when the next release will ship?

samtsai commented 5 years ago

Bump, I still do not see this option available. Can we get a new release?

howardcvalve commented 4 years ago

Hi @stef-levesque, would you be able to publish a new release with this feature?

samtsai commented 4 years ago

@stef-levesque any chance we could get this released?

mjcrouch commented 4 years ago

HI @samtsai

This was in master before I made my fork - so it's in the published version if you want to try it.

(I just tried it and did notice a minor issue that if you don't have perforce.annotate.user enabled, all the swarm links have the text "undefined" in them)

(don't forget to disable slevesque.perforce before using it or everything goes crazy)

samtsai commented 4 years ago

So I'm able to see the links now! Unfortunately the link points to: https://SWARM_HOST/changes/NUM

I'm not sure my company's Swarm is setup that way, I'd ideally want to point to the specific file and change number.

mjcrouch commented 4 years ago

I've never used swarm so I'm not sure how the links work but it purports to be free so I may see if I can do something about it when I get a chance

mjcrouch commented 4 years ago

Also it occured to me the default annotation view shows revisions instead of changelist numbers, but there's a setting to change it, which will affect the link it generates

Don't know if that makes a difference for your swarm setup, but definitely this change needs some more work as it's only compatible with certain settings