search

stef-levesque / vscode-perforce

Perforce basic commands for Visual Studio Code
MIT License
74 stars 103 forks source link

fix executeCommand in PerforceService.ts #180

Closed dorian-bian closed 3 years ago

dorian-bian commented 4 years ago

The last parameter must be a callback and call it when passing it as a parameter of 'limiter.submit', or it won't work as expect.

When using submit(), make sure all the jobs will eventually complete by calling their callback, or set an expiration. Even if you submitted your job with a null callback , it still needs to call its callback. This is particularly important if you are using a maxConcurrent value that isn't null (unlimited), otherwise those not completed jobs will be clogging up the limiter and no new jobs will be allowed to run. It's safe to call the callback more than once, subsequent calls are ignored.

stef-levesque commented 3 years ago

This extension is being deprecated, please have a look at mjcrouch 2020 Fork