stef-levesque / vscode-perforce

Perforce basic commands for Visual Studio Code
MIT License
74 stars 103 forks source link

deleteOnFileDelete:true re-marks files as deleted if removed via P4V Client #182

Open andykelts opened 4 years ago

andykelts commented 4 years ago

I'm on VS Code version 1.41.1 Perforce for VS Code 3.2.0

With deleteOnFileDelete:true, performing a sync in the P4V client will cause files that have been removed from the depot to now be marked as Open for Delete.

For example: User A syncs to head revision on a folder. User B deletes several files in that folder and then submits those deletes. With VS Code open, User A now syncs to head revision on that same folder. The files that User B deleted are now removed from User A's system, but VS Code detects that removal and marks those same files for delete. The files are no longer on disk, but the Default Changelist now has all of those deleted files showing up as open for delete.

I would expect VS Code to detect the removal of those files and then verify whether they have been intentionally removed before doing a second Open for Delete on a file that's already deleted.