stef / libopaque

c implementation of the OPAQUE protocol with bindings for python, php, ruby, lua, zig, java, erlang, golang, js and SASL.
GNU Lesser General Public License v3.0
69 stars 10 forks source link

Js app infos update #19

Closed stef closed 3 years ago

stef commented 3 years ago

please have a look @creemama at my feeble attempt at updating the js bindings. i have no emscripten environment, so i couldn't test this.

basically what it boils down to, is that the app_infos only has one info and one einfo field, and userauth does not receive an appinfos structure as a parameter anymore.

happy to learn from your fixes to this, how to work this wrapper so i can be more independent the next time.

thank you very much for all your kind support!

stef commented 3 years ago

hmm, the checks failed. hrmpf. will have a look at this tomorrow. now zzzzz

creemama commented 3 years ago

@stef, js/wrapper/libopaque-pre.js is where all the magic happens.

There's no need to update the files in dist manually. Running make generates dist's contents.

I was eyeing to make this change to info myself. I'm glad I held off.

stef commented 3 years ago

i see. thank you for fixing my mess again :)

i wonder, why do we have generated files in the gitrepo? can we remove everything that can be generated via the makefile? or why is this a bad idea?

creemama commented 3 years ago

Unlike other languages, including compiled JavaScript source in a dist directory is not uncommon for JavaScript projects. See the following Git repos:

For us, the benefit of doing this is making the JavaScript and PHP demos easier to run. Setting up and compiling using Emscripten is a little painful.