make should produce a release build by default

stef / libopaque

c implementation of the OPAQUE protocol with bindings for python, php, ruby, lua, zig, java, erlang, golang, js and SASL.

GNU Lesser General Public License v3.0

69 stars 10 forks source link

make should produce a release build by default #5

Closed creemama closed 3 years ago

creemama commented 3 years ago

I brought over @stef's makefile change from https://github.com/stef/libopaque/commit/871f64d39e585b44d16c0e950bcb546053937a19 and made modifications.

@stef, should -fPIC and -fpic both be specified in CFLAGS?

stef commented 3 years ago

-fPIC works everywhere but on certain platforms generates a bit bigger code. since we don't use a whole lot of GOT space i think -fpic is a preferable choice - that only makes a difference on non-linux systems.

thanks for this PR, the dev defaults are dangerous for people trying to blindly use this lib.