search

stef / pyrsp

python implementation of the GDB Remote Serial Protocol
83 stars 20 forks source link

Python 3 #11

Closed laerreal closed 5 years ago

laerreal commented 5 years ago

I have managed to make pyrsp working under Python 3 (3.5.2 actually). Please read commit messages for explanation of corresponding changes.

Also note that because of rebasing in course of patch preparation, GitHub may confuse the patch order.

stef commented 5 years ago

wow.

laerreal commented 5 years ago

Fixed "python3 -m unittest test" command from a terminal. I normally launched the tests from Eclipse IDE, so I missed that problem.

stef commented 5 years ago

i tested it under py 3.7, and made only two small changes. one is the joining of the printout in dump_mpu() into one line, and the other is related to the loading of the virtualenv at the beginning of rsp.py, it seems that py3 does not implement execfile anymore. i really hate py3.

Vasily thank you very much for this monster of a patch, must have been agony to put all those () in the prints and the b prefixes to strings.

<3

stef commented 5 years ago

i also bumped the version to 0.4 and pushed a pkg to pypi.

stef commented 5 years ago

and sorry for this taking so long. somehow i thought i already merged this and forgot about it, only today i noticed that this is still pending.

laerreal commented 5 years ago

Good =)