search

stefalda / ReactNativeLocalization

Class to localize the ReactNative interface
MIT License
899 stars 124 forks source link

Resolve some unmet peer dependency warnings #212

Closed neilco closed 2 years ago

neilco commented 2 years ago

This pull request resolves the following peer dependency warnings:

  1. Our project had an unmet peer dependency on react-native-windows—not every React Native app targets Windows so this should an optional peer dependency.

  2. This project didn't provide react as request by the react-localization dependency, breaking the requirement:

    "react": "^17.0.0 || ^16.0.0 || ^15.6.0"

    Adding "react": ">16.0.0" as a peer dependency resolves this warning. Note: the required version is >16.0.0 and not > 15.6.0 because react-localization has the following dev dependency specification for react: 

    "react": "^16.0.0"