search

stefalda / ReactNativeLocalization

Class to localize the ReactNative interface
MIT License
898 stars 123 forks source link

Issue with 2.3.0 (missing commit) #213

Closed neilco closed 2 years ago

neilco commented 2 years ago

This is just an FYI:

There's an issue with v2.3.0 in that it's missing a commit from #212. This is because you bumped the version before merging the pull request. As a result, yarn is still not treating react-native-windows as an optional dependency and generates an unmet peer dependency warning.

When you don't use GitHub releases or git tags to specify the latest release, the package registries resolve the latest version to the commit where the version number changed. In this case, you merged the pull request after bumping the version to 2.3.0 and so 2.3.0 doesn't contain everything from #212.

stefalda commented 2 years ago

Thanks @neilco I should have fixed it