search

stefan-gr / abendbrot

Desktop oriented overlay for various ebuilds and the occasional gamer
19 stars 13 forks source link

Add games-emulation/reicast #101

Closed crocket closed 6 years ago

crocket commented 6 years ago

I confirmed that both -9999 and -7_pre28100310 build and run on my system. Because I still don't have a clean gentoo build environment, it might fail to build on other systems.

I don't know whether 7_pre20180310 is a correct version for reicast.

stefan-gr commented 6 years ago

Thanks, that should work. The only tings I would do differently is using "repoman manifest" to get slimmed down manifest files and using SRC_URI="https://github.com/reicast/reicast-emulator/archive/b4631f6715ab7ee8483ebcef37a97f6e3194602e.tar.gz -> ${P}.tar.gz" So that git-r3 can be ditched completely on non-9999 ebuilds, otherwise people need a working internet connection to reemerge that ebuild. Downside is that github only generates archives without submodules, but this one doesn't use them anyway.

You should also set the noreply email from github so that your commits are actually credited to your account. layman likes to insert it's own address in managed overlays, overwriting global git settings that way. If you want to you can close this PR and resubmit it with correct email. Just say the word and will merge this in spite of that.

crocket commented 6 years ago

I don't know how to use repoman, yet. But, I changed my email address to my private email address generated by github and substituted SRC_URI for git-r3.

stefan-gr commented 6 years ago

Thanks, repoman is used when cd'ed to the folder of ebuilds you want to check. Basic usage is repoman -p full to see what portage has to say about the ebuilds, repoman manifest to generate manifest for all ebuilds in the directory and repoman commit which does a check similar to repoman full and then uses a template to generate a commit with it when it didn't found anything to complain about.