search

stefan-hoeck / idris2-pack

BSD 3-Clause "New" or "Revised" License
90 stars 23 forks source link

Install curl in CI #290

Closed joelberkeley closed 1 month ago

buzden commented 1 month ago

Any clue why?

joelberkeley commented 1 month ago

@buzden I don't understand the question. spidr requires curl to install, as does pack's primary installation route. I don't know the full reasons, but stefan suggested we add curl to the builds https://discord.com/channels/827106007712661524/841274390481600562/1249031320399773738

joelberkeley commented 1 month ago

I must admit I'm only confident, not certain, it's a good idea myself. curl is a reasonably lightweight dependency that will exist on most user systems

Perhaps I shouldn't add it to the Dockerfile since not everything requires it. Even spidr is very explicit that it's a build dependency ... yeah I'll remove it there

joelberkeley commented 1 month ago

I guess the danger is that someone's installation requires curl but doesn't say it does, passes in pack-db CI, then fails when someone tries to install it. TBH that seems like a pretty small problem, and also unlikely to happen since curl is in most places, and usually used to install pack

joelberkeley commented 1 month ago

this whole PR was a misunderstanding. stefan meant in pack-db not here