In create_datasets.ipynb Bond Price Indexes DataSource[GOLDAMGBD228NLBM] is Not ready

stefan-jansen / machine-learning-for-trading

Code for Machine Learning for Algorithmic Trading, 2nd edition.

https://ml4trading.io

12.87k stars 4.11k forks source link

In create_datasets.ipynb Bond Price Indexes DataSource[GOLDAMGBD228NLBM] is Not ready #225

Closed starfire-lzd closed 2 years ago

starfire-lzd commented 2 years ago

Describe the bug when I use create_datasets.ipynb to download data, the GOLDAMGBD228NLBM in Bond Price Indexes is count fetch

To Reproduce master

Expected behavior RemoteDataError: Unable to read URL: https://fred.stlouisfed.org/graph/fredgraph.csv?id=GOLDAMGBD228NLBM

Environment If you are not using the latest version of the Docker imag:

OS: [e.g. MacOSX, Windows, Ubuntu]
- WSL2
- python3.8

stefan-jansen commented 2 years ago

Unfortunately, this data has been recently removed from the FRED service. I'll use a different dataset when I update to the next edition and will add a warning in the notebook. Sorry about this, but not much I can do.

CDLim0906 commented 2 years ago

Hi, I am having the same issue. Are these data ('GOLDAMGBD228NLBM': 'Gold (London, USD)') important later in the chapter? Regards

stefan-jansen commented 2 years ago

Nope, they are not important.

CDLim0906 commented 2 years ago

Oh, thanks for the reply, and also, thanks for putting up such a great book.