stefan-jansen / machine-learning-for-trading

Code for Machine Learning for Algorithmic Trading, 2nd edition.
https://ml4trading.io
12.87k stars 4.11k forks source link

#Chapter 11 - 00_data_prep.ipynb Broken links #249

Closed saad-ibrahim closed 2 years ago

saad-ibrahim commented 2 years ago

Hi,

In Chapter 11 and the first notebook 00_data_prep.ipynb the links send me to a 404 error. There are three links that do not work and are found in the following sentences:

_"We create the dataset here and store it in our [data] folder to facilitate reuse in later chapters."

"The assets.h5 store can be generated using the the notebook [createdatasets] in the [data] directory in the root directory of this repo for instruction to download the following dataset."

Naturally I would need access to these to follow along with the example so I would appreciate it if you can take a look into this as soon as possible.

Thanks!

stefan-jansen commented 2 years ago

First link refers to data in repo root . create_datasets can be found in this directory. Hope this helps.