Closed marctheshark3 closed 1 year ago
I raised PR for the same https://github.com/stefan-jansen/machine-learning-for-trading/pull/254
@marctheshark3 thank you for putting this here ... it is working for me now ... seems like this issue should be fixed as it is literally the first thing they ask you to do lol :) ... hopefully he gets around to this fix because there is no ftp and the url is wrong @stefan-jansen
Fixed by #254, thanks.
Describe the bug When running
file_name = may_be_download(urljoin(FTP_URL, SOURCE_FILE))
First, there isnt a variable called FTP_URL, and when changed to HTTPS_URL, you get an invalid URL error.
This doesnt work:
HTTPS_URL = 'https://emi.nasdaq.com/ITCH/Nasdaq ITCH/'
This DOES work:
HTTPS_URL = 'https://emi.nasdaq.com/ITCH/Nasdaq%20ITCH/'
To Reproduce