Feature/shutter control

stefan-kaestle / openhab2-addons

Add-ons for openHAB 2.x

Eclipse Public License 2.0

16 stars 1 forks source link

Feature/shutter control #2

Closed coeing closed 4 years ago

coeing commented 4 years ago

TODO:

[x] Stopping not working as implemented, check if possible or remove
[x] Add PercentType command to set precise percentage of shutter level
[x] Move service name "ShutterControl" into constant variable
[x] Remove Gateway-ID from header of putState request

coeing commented 4 years ago

Stopping the shutters from moving doesn't seem possible with the current API, so I created an issue for it: https://github.com/BoschSmartHome/bosch-shc-api-docs/issues/34

Maybe I can find a workaround in the meantime.

coeing commented 4 years ago

Alright, this was a short but very successful coding session :) I handled all the remaining TODOs, so from my side the pull request is ready to merge. But please check if it is okay from your side as well!

I am using some general functions that can also be used in other places, but I would like to do the refactoring in a separate branch.

Next time I have time I will add some issues for the parts I'd like to change, so we can discuss them if necessary.

coeing commented 4 years ago

@stefan-kaestle Thanks for the review :)

About your points:

I can add some information about the new supported thing to the Readme.md, that's a good point!
I would suggest to have a list of contributors in the Readme.md and not in every single code file. If anybody is interested who created which code fragment, he/she could easily use Git Blame for it :)

If you give me write access to the repository, I'll merge my branch after the addition of the shutter control info to the Readme.md. Otherwise I'll let you know when I did the addition :)

coeing commented 4 years ago

Alright, I added the Shutter Control device to the supported device section of the Readme.md and added a null reference check because on initialization the device state doesn't seems to be fetched correctly.

Will merge the pull request now! :scream:

stefan-kaestle commented 4 years ago

Great work! Thanks Christian! :tada::tada::tada::tada: