search

stefan-kaestle / openhab2-addons

Add-ons for openHAB 2.x
Eclipse Public License 2.0
16 stars 1 forks source link

run.sh still required? #29

Closed coeing closed 3 years ago

coeing commented 3 years ago

I just stumbled upon the "run.sh" file in the root folder of our bundle. Is that script still required? If not we should throw it out :)

coeing commented 3 years ago

Furthermore the "install.sh" script seems to have only local paths. We should either not have it under version control or make the paths configurable, so it can be used by all developers.

GerdZanker commented 3 years ago

Furthermore the "install.sh" script seems to have only local paths.

I used the script to get some infos and ideas for my own steps to compile and test the JAR. My recommendation is to remove the script and write instead some word for developers into the readme. What do you think?

coeing commented 3 years ago

@GerdZanker Sounds good, we can add a Developers section to the README.md. Feel free to use the already existing pull request #31 to adjust the file :)

GerdZanker commented 3 years ago

Feel free to use the already existing pull request #31 to adjust the file :)

Perfect! But I can't promise a time frame for the dev section, therefore merge at any point in time and depending on the state I will reuse your PR or create a new one.

coeing commented 3 years ago

@GerdZanker In that case I'll merge it as soon as we resolved the last issue of #31 and you can adjust the README.md when you have time :)