Fix code analysis warnings

stefan-kaestle / openhab2-addons

Add-ons for openHAB 2.x

Eclipse Public License 2.0

16 stars 1 forks source link

Fix code analysis warnings #47

Closed coeing closed 3 years ago

coeing commented 3 years ago

Right now we have a lot of code analysis warnings popping up during a Maven build:

mvn install

The code analysis report can be found at openhab-addons/bundles/org.openhab.binding.boschshc/target/code-analysis/report.html afterwards.

We have probably all skipped the code analysis during our work, so the warnings piled up. In the future we should run a normal build each time we merge a pull request.

For now we should fix those as soon as possible to avoid code smells.

coeing commented 3 years ago

Fixed some first warnings in my classes, 34 warnings left :)

coeing commented 3 years ago

Warnings left:

[x] 3 TODOs in BoschSHCBridgeHandler.java and BoschSslUtil.java (we should turn those into issues)
[x] AvoidThrowingRawExceptionTypes in BoschSHCHandler.java

coeing commented 3 years ago

Fixed remaining warnings. If new ones should arrive, we should open new issues for each one (or a group of them) to avoid having long open issues :)