search

stefan-kaestle / openhab2-addons

Add-ons for openHAB 2.x
Eclipse Public License 2.0
16 stars 1 forks source link

fix HTTP client issue, improve connection logging, add Developers markdown #50

Closed GerdZanker closed 3 years ago

GerdZanker commented 3 years ago

The BoschHTTPClient requests were broken and I fixed the create*() code and String.format(...). Updated exception handling and logging for connection and pairing. Described the source of certificates, compare PR findings.

The PR findings regarding pairing are pending, but I was able to learn from the Hue binding how the pairing and polling are implemented there. I think a similar PollingRunnable class + instances code and the scheduloing with scheduler.scheduleWithFixedDelay will fit for us too.

coeing commented 3 years ago

Damn, I thought I tested my changes, but maybe openHAB still used an old binding jar :/ Thanks for the fix of String.format!

Found the bug in my local setup. openHAB had cached version 2.5.1 of our bundle and loaded it instead of the updated 2.5.9 version :/ Hope I didn't introduce too many other bugs with my refactorings!