search

stefan-kaestle / openhab2-addons

Add-ons for openHAB 2.x
Eclipse Public License 2.0
16 stars 1 forks source link

Wall Thermostat #96

Closed coeing closed 3 years ago

coeing commented 3 years ago

Closes #25

stefan-kaestle commented 3 years ago

Code looks good, don't have a wall thermostat, so can't test :-)

Have to say the code is soo much cleaner now vs a year ago! Amazing work @coeing and @GerdZanker

tuxianerDE commented 3 years ago

@stefan-kaestle @coeing I can do the test since I have two of them running here would require an updated binary file though.

coeing commented 3 years ago

@tuxianerDE Thanks for your offer! I will build a new jar file this week with this feature in it :)

coeing commented 3 years ago

Code looks fine. A first short tests with a locally compiled JAR resulted in a

[WARN ] [ore.thing.internal.ThingRegistryImpl] - Cannot create thing. No binding found that supports creating a thing of type 'boschshc:wall-thermostat'.

and the device is UNINITIALIZED. Therefore I want to take more test time before approval.

Oh, it is possible that I forgot adding the new handler to our Factory :O Good thing you tested it ;) Will have a look at it tomorrow!

coeing commented 3 years ago

@GerdZanker Added the wall thermostat handler to our handler factory, now it should be usable :)

GerdZanker commented 3 years ago

I setup just one Wallthermostat and openhab received the humidity and temperature value of it. Together with the device discovery I will do more tests, will all of my wall thermostats.