search

stefan-kolb / nucleus

Platform as a Service API abstraction layer.
MIT License
28 stars 0 forks source link

Behaviour when .credentials or any adapter attributes are missing #50

Closed stefan-kolb closed 9 years ago

stefan-kolb commented 9 years ago

Does it fail fast?

croeck commented 9 years ago

Not as fast as it probably could. I did not include additional validation as recording (where the credentials are needed) must be triggered manually. For attributes, if you refer to the spec attributes, there is also no check. The adapter configurations were initially supposed to fail fast with the schema validation, but this was removed as discussed earlier. I think there should still be a test covering this scenario. However, it would only cover missing attributes, but not verify them.

PS: If it is important I would look it up later today, but I currently do not have access to my IDE

stefan-kolb commented 9 years ago

@croeck It's not time critical :wink:, I'm just working on some minor things that got in my way while testing.

stefan-kolb commented 9 years ago

c5ca07e648c503392e816fe3b91428a887690d3d