search

stefan-langenmaier / brother-overlay

Portage overlay for Brother printer and scanner software
GNU General Public License v3.0
34 stars 41 forks source link

Updated brscan3, added driver for MFC-7440N #15

Closed fonic closed 8 years ago

fonic commented 8 years ago

I added ebuilds for the latest brscan3 driver and for the MFC-7440N model.

Great repository by the way!

stefan-langenmaier commented 8 years ago

Hi,

thanks for your contribution! The version bump for the scanner looks good to me. The printer driver looks like a copy of the generic printer driver but with a modified patch. Correct me if I'm wrong. At the moment the driver for mfc7440 would be conflicting with the generic driver. Do you think you could just merge it with the generic driver or should I add a dependency so that they cannot be installed at the same time?

Thanks again for your time!

fonic commented 8 years ago

Sorry that it took me a while to respond.

My mistake - the driver for mfc7440 is an unmodified copy of mfc7460 since I somehow missed that there already is a package for the generic driver (brother-genml1-bin).

So it's only the brscan3 version bump that should be merged. Can you do a partial merge or should I issue a new pull request?

stefan-langenmaier commented 8 years ago

I just wanted to understand your rationale why you created another package. :) And this got me reminded of the package for the mfc7460.

I have created an issue for this clean up #17. If you want to work on it, tell me, as I won't have time the next one or two weeks.

For the moment I will take your pull request as it is. I hope it's not a problem if the mfc7440 package will be changed or removed in the future.

Thanks for the feedback.