stefan-langenmaier / brother-overlay

Portage overlay for Brother printer and scanner software
GNU General Public License v3.0
34 stars 41 forks source link

Brother-hl1118 support. #35

Closed ghost closed 7 years ago

ghost commented 7 years ago

Hello,

Please, may you consider add in an ebuild for Brother HL-11xx series?

This one support: Brother HL-1110, HL-1110R, HL-1111, HL-1112, HL-1112R, HL-1118.

There is a PKGBUILD on Arch Linux AUR.

Thank you!

stefan-langenmaier commented 7 years ago

Hi,

the printer looks similar to hl3140cw. It could be copied from that and should work with a couple replacements. If you want you can make a pull request. If you need help just ask. Otherwise I hope I can do it on the weekend.

stefan-langenmaier commented 7 years ago

I added the model. Please let me know if it works as I can't really test it.

ghost commented 7 years ago

Thank you! Sorry about the delay, just now I see your comments.

I do not have access to the printer right now, but I will try it ASAP.

ghost commented 7 years ago

Hi,

Just a minor typo on ebuild line 55. Where it read (hl1110):

( cd "${D}/usr/libexec/cups/filter/" && ln -s ../../../../opt/brother/Printers/HL1110/lpd/filter_HL1110 brother_lpdwrapper_hl1110 ) || die

it should be indeed (HL1110):

( cd "${D}/usr/libexec/cups/filter/" && ln -s ../../../../opt/brother/Printers/HL1110/lpd/filter_HL1110 brother_lpdwrapper_HL1110 ) || die

Other than that, it is working quite fine.

Thank you!

stefan-langenmaier commented 7 years ago

Is it causing a problem or why has it to be changed?

ghost commented 7 years ago

Oh, sorry, it was not printing because the file could not be found by Cups at /usr/libexec/cups/filter/ due to the sym-linked file being named with lowercase "hl".

Thank you!

stefan-langenmaier commented 7 years ago

I included your correction.

Thanks for your feedback. I'm closing the issue. Don't hesitate to reopen if you an issue.

Best regards Stefan