search

stefan-langenmaier / brother-overlay

Portage overlay for Brother printer and scanner software
GNU General Public License v3.0
34 stars 42 forks source link

MFC-9340CDW fixes #55

Closed EvaSDK closed 6 years ago

EvaSDK commented 6 years ago

Just got myself one of these. I was grateful for the work available in this overlay so I thought I would contribute some fixes to make it more in line with Gentoo standards.

Most important changes is using ebuild functions rather than blind cp.

The second important bit here is the extraction of the cups wrapper script to replace the buggy symlink. Since this script is generated by executing the one provided by cupswrapper, I chose to extract it in ${FILESDIR}.

I successfully printed a couple of pages using various options directly from the Gnome control center or evince and they were properly reflected to the print which was not the case before.

EvaSDK commented 6 years ago

Note that there is probably more to be done to make the ebuild cleaner, but this is a start :)

stefan-langenmaier commented 6 years ago

Hi,

thanks for the cleanup and the infos!