search

stefan-langenmaier / brother-overlay

Portage overlay for Brother printer and scanner software
GNU General Public License v3.0
34 stars 41 forks source link

add missing IUSE avahi in some metadata.xml files #83

Closed mehw closed 4 years ago

mehw commented 4 years ago

Fixes IUSE.invalid: This ebuild has a variable in IUSE that is not in the use.desc or its metadata.xml file.

stefan-langenmaier commented 4 years ago

Woohoo! Repoman is happy again!

mehw commented 4 years ago

HI @stefan-langenmaier,

This PR should fix the last Travis error left.

I plan more PRs. Time will be invested to conform ebuild and metadata.xml files, their indentation, possible typos, variables, structure, etc. This will be time consuming...

ebuilds may get a file rename, following the template brother-PN-PV_pX rather than brother-PN-PV-PR (i.e. brother-dcp9040cn-bin-1.0.3_p1.ebuild rather than either brother-dcp9040cn-bin-1.0.3.1.ebuild or brother-dcp9040cn-bin-1.0.3-r1.ebuild), because the last numeric suffix means a revision of the driver, and not of the ebuild file itself.

What do you think @stefan-langenmaier about ebuilds renaming?

Woohoo! Repoman is happy again!

Cheers ;)

stefan-langenmaier commented 4 years ago

HI @mehw,

I have no problem with renaming the files. The more they are aligned with the default template the better. My question is how will this impact people that have this printer currently installed. Will it be updated? If yes, then we are causing an unneeded reinstall of a package. As these packages are small and binary there is no time/resource problem. But in the back of my mind I remember that some packages had issues when they are reinstalled that they are overwriting the user made changes.

As far as I remember this was mostly for the scanner packages, like in media-gfx/brother-scan3-bin where there is some configuration in /usr/local/Brother/sane/brsanenetdevice3.cfg and /etc/sane.d/dll.d/brscan3.conf.

This legacy issue shouldn't be a reason to not update the ebuilds, but I just wanted to make you aware of the cruft. :-/

mehw commented 4 years ago

Hi @stefan-langenmaier,

Your concern about loosing customizations of configuration files is well placed. I tried to address that setting the CONFIG_PROTECT variable, which is discussed in PR #88. Forgive me for taking so long to answer. In the last few days I dedicated lots of time thinking on how to align the ebuilds, and I refrained from posting until I adopted the path described in the PR.

PS: Simply put, and if I'm not wrong, an upgrade is triggered when there is a version (unmasked) that compares greater than the installed one. A downgrade is performed when the currently installed ebuild is removed. A reinstallation is "tricky". A new/removed use flag in the ebuild does indeed provoke a reinstallation, but a change in the variable RESTRICT does not...:

# emerge --ask --update --deep --with-bdeps=y --newuse -v @world

Cheers!