stefan-langenmaier / jami-overlay

Jami (formerly Ring (formerly SFLphone)) is a SIP compatible softphone for GNU/Linux.
GNU General Public License v3.0
21 stars 9 forks source link

Add use flags for configure options #17

Closed stefan-langenmaier closed 7 years ago

stefan-langenmaier commented 7 years ago

Add more use flags for ring-daemon configure options.

Optional Features:
  --disable-video         Disable video
  --disable-accel         Disable all hardware accelerations
  --disable-vaapi         Disable VAAPI hardware acceleration
  --enable-ipv6           Enable IPv6 support
  --enable-doxygen        enable documentation generation with doxygen (disabled by default)
  --enable-dot            use 'dot' to generate graphs in doxygen (auto)
  --enable-debug          Build in debug mode, adds stricter warnings, disables optimization

Optional Packages:
  --without-opensl        Ignore presence of opensl and disable it
  --without-alsa          disable support for alsa
  --without-pulse         disable support for pulseaudio
  --without-jack          Ignore presence of jack and disable it
  --without-portaudio     disable support for portaudio
  --without-dbus          disable support for dbus
  --with-restcpp          enable rest support with C++
  --without-sdes          disable support for sdes key exchange
  --without-gsm           disable support for gsm codec
  --without-speex         disable support for speex codec
  --without-speexdsp      disable support for speexdp Noise Suppression and Automatic Gain Control
  --with-libilbc          support ilbc audio [default=check]
  --with-opus             support opus audio [default=check]
  --without-upnp          disable support for upnp
  --without-natpmp        disable support for NAT-PMP
YogSottot commented 7 years ago

I'm made 1st variant of reworked USE for ring-daemon https://github.com/YogSottot/ring-overlay/commit/b963a9bae9144204ea94853baae8f6e09a9b959e What is your opinion?

Also add some USE for libringclient. Delete one unneeded dep for opendht. (dev-libs/nettle - it is gnutls dep.)

opendht/rules.mak:DEPS_opendht += msgpack
opendht/rules.mak:DEPS_opendht += gnutls $(DEPS_gnutls)
    gnutls/rules.mak:DEPS_gnutls = nettle $(DEPS_nettle) iconv $(DEPS_iconv)
        nettle/rules.mak:DEPS_nettle = gmp $(DEPS_gmp)

Also, i'm have a question:

sed -i.bak 's/LIBS = \(.*\)$/LIBS = \1 -lopus /g' bin/Makefile

Is this sed string really need? Without this string "lopus" is added in "opus_LIBS". Whats wrong with it?

--with-opus
Makefile
opus_CFLAGS = -I/usr/include/opus
opus_LIBS = -lopus

Also >=media-video/ffmpeg-.1.3[v4l] - is this really need?

# Linux
ifdef HAVE_LINUX
FFMPEGCONF += --target-os=linux --enable-pic
ifndef HAVE_ANDROID
FFMPEGCONF += --enable-indev=v4l2 --enable-indev=x11grab_xcb --enable-indev=x11grab --enable-x11grab
else
# used to avoid Text Relocations
FFMPEGCONF += --extra-cxxflags=-fPIC --extra-cflags=-fPIC
FFMPEGCONF += --disable-asm
endif
endif
YogSottot commented 7 years ago

Also, what is your opinion about this?