search

stefan-langenmaier / jami-overlay

Jami (formerly Ring (formerly SFLphone)) is a SIP compatible softphone for GNU/Linux.
GNU General Public License v3.0
22 stars 9 forks source link

net-voip/ring-daemon: HW acceleration build options (VDPAU, VAAPI) removed in upstream #55

Open steils opened 6 years ago

steils commented 6 years ago

Since commit 2cc09ccc (https://gerrit-ring.savoirfairelinux.com/8043) --disable-vdpau and --disable-vaapi are removed from ring-daemon, leaving only --disable-accel. net-void/ring-daemon doesn't build without USE flag 'vdpau' because of that.

I see two possible approaches: a) Remove 'vdpau' and 'vaapi' from IUSE, add x11-libs/libvdpau to dependencies when 'hwaccel' is enabled. But that would force to install libvdpau even with global USE="-vdpau" (bad). b) Add a patch returning the flags --disable-vdpau and --disable-vaapi to configure.ac in ring-daemon. That would make vdpau and vaapi USE flags meaningful again. But it has purpose only in Gentoo, and probably such a patch will require some maintenance here (not in upstream), and I don't know how much work is that. For now I can just say that ring-daemon successfully configures and builds without libvdpau on my system if I return --disable-vdpau build option.

See also: https://tuleap.ring.cx/plugins/tracker/?aid=1883 (probably will be declined as notabug/wontfix but anyway) https://tuleap.ring.cx/plugins/tracker/?aid=1884

stefan-langenmaier commented 6 years ago

Thanks for the references. I would opt for solution a) as this would follow upstream. The patch looks minimal but if they don't have the man power to support the option... Anyway if you like to create a patch we can add it and we'll see how it behaves in the future.