stefan-niedermann / nextcloud-deck

📋 Android client for nextcloud deck app
https://play.google.com/store/apps/details?id=it.niedermann.nextcloud.deck.play
GNU General Public License v3.0
495 stars 53 forks source link

Renaming and order of lists not synced via ETags option #1586

Closed j-lakeman closed 8 months ago

j-lakeman commented 8 months ago

This issue respects the following points:

Describe the bug

  1. ETags option enabled in app
  2. add new list on server
  3. rename list on server or change order of lists
  4. sync with app
  5. only first ever given name / position is synced

Expected behavior

The ETags mode should also sync renaming or changing order of lists, just like in “normal” mode.

Deck Android version

1.23.4

Deck server version

1.12.2

Nextcloud Android version

3.27.0

Nextcloud version

28.0.2

Device

Google Pixel 5

Android Version

14

App Store

Stacktrace

No response

stefan-niedermann commented 8 months ago

The ETags mode should also sync renaming or changing order of lists, just like in “normal” mode.

No, it should not. For the simple reasons that if the ETags are not updated on the Deck server app, we don't know whether the content (= order, title, ...) changed. This means, we would need to fetch the stack which matches exactly the behavior of disabled ETags: Fetching everything from everywhere. Takes ages, causes lot of traffic.

We will not workaround this bug of the Deck server app. Please go the corresponding Deck server app issue: https://github.com/nextcloud/deck/issues/2866 - Feel free to upvote it or provide a PR fixing the root cause of the issue.

stefan-niedermann commented 8 months ago

Also referring to the FAQ

j-lakeman commented 8 months ago

Alright, sorry for the confusion. Thanks for your work!