search

stefan-niedermann / nextcloud-deck

📋 Android client for nextcloud deck app
https://play.google.com/store/apps/details?id=it.niedermann.nextcloud.deck.play
GNU General Public License v3.0
501 stars 53 forks source link

fix: card title color #1675

Closed Ornanovitch closed 2 months ago

Ornanovitch commented 2 months ago

On master, the colorEditText color is unreadable since some updates of nextcloud/android-common (here I guess)

This commit makes the card title readable again with a more used and (stable?) function, colorTextView with the param ColorRole.ON_SURFACE

Before After
title-before title-after
stefan-niedermann commented 2 months ago

Thank you for the contribution! Shouldn't this fixed upstream in the android-common library? I didn't look at the code yet, but I think the colorEditText method handles more stuff than the colorTextView method (cursor color, the color of the bottom line etc...)?

Ornanovitch commented 2 months ago

Oh! Could it be that?

https://github.com/nextcloud/android-common/commit/50e641ee33a834ab89315ea86bf6cb2bb0f40b58#diff-f2305b95fc7795d7fc2ff8c309ead47432f28737b0fb5336b690876a48623572R620

- editText.setTextColor(scheme.onSurface)
+ editText.setTextColor(dynamicColor.surface().getArgb(scheme)) // -> .onSurface becoming .surface
Ornanovitch commented 2 months ago

superseded by https://github.com/nextcloud/android-common/pull/502

Let's close this until we can see the library changes