stefan-niedermann / nextcloud-deck

📋 Android client for nextcloud deck app
https://play.google.com/store/apps/details?id=it.niedermann.nextcloud.deck.play
GNU General Public License v3.0
501 stars 53 forks source link

card title color (colorEditText) invisible after Android common update #1678

Open Ornanovitch opened 2 months ago

Ornanovitch commented 2 months ago

This issue respects the following points:

Describe the bug

Follow-up after https://github.com/stefan-niedermann/nextcloud-deck/pull/1675 and https://github.com/nextcloud/android-common/pull/502

  1. Click on a card
  2. You can't read the title but you can select/edit it
Screenshot

![image](https://github-production-user-asset-6210df.s3.amazonaws.com/34077099/367885988-d9911b3a-ea27-4392-b344-f56752440177.png?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20240922%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240922T124045Z&X-Amz-Expires=300&X-Amz-Signature=494041900a654ec0de3487430b002b8f1b1bae0e92c73d8147abe10296cabcc6&X-Amz-SignedHeaders=host)

The colorEditText function seemed to be in cause because we found some problems into it, but those had been fixed without solving the issue in my tests.

Here is the issue:

https://github.com/stefan-niedermann/nextcloud-deck/blob/8cea58ac5a0b5b21d2b594ec7f0bb057fda5d84f/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/EditActivity.java#L280-L294

The interesting thing is that this element is the only place where colorEditText function is used in the whole app. Plenty of other EditText elements are used without this kind of theming parameter, and are working normally.

Expected behavior

Title should be readable

Deck Android version

dev

Deck server version

not relevent

Nextcloud Android version

not relevent

Nextcloud version

not relevent

Device

Samsung Galacy A5 2017

Android Version

12

App Store

Stacktrace

No response

stefan-niedermann commented 2 months ago

Are you absolutely sure regarding the correct tested lib version? There is a transitive dependency to the lib from nextcloud-commons, and I suspect it will pick the there used release version over the not-released version directly embedded in the Deck Android App.

Ornanovitch commented 2 months ago

Are you absolutely sure regarding the correct tested lib version? There is a transitive dependency to the lib from nextcloud-commons, and I suspect it will pick the there used release version over the not-released version directly embedded in the Deck Android App.

I didn't suspect a version problem on the lib side, but you're right, it's too strange to not be investigated! However right now I don't know how to inspect the library version in use after a build. I'll try to check this out.

AndyScherzinger commented 2 months ago

I published 0.23.1, so the simplest thing would be to bump the lib version in all places to this one, than no matter which one gets picked it is always the same version.

stefan-niedermann commented 1 month ago

I'll publish new versions this weekend 👍

stefan-niedermann commented 1 month ago

Alright, nextcloud-commons:2.3.1 has been published and it includes android-common:0.23.1

Ornanovitch commented 1 month ago

It works with android-common:0.23.1! :fireworks: