stefan-niedermann / nextcloud-deck

๐Ÿ“‹ Android client for nextcloud deck app
https://play.google.com/store/apps/details?id=it.niedermann.nextcloud.deck.play
GNU General Public License v3.0
490 stars 53 forks source link

Tag dropdown in card editor doesn't show tags which were removed in same edit activity. #862

Open ghost opened 3 years ago

ghost commented 3 years ago

Please use GitHub reactions ๐Ÿ‘ to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug

To reproduce Issue is reproducible with an account from try.nextcloud.com:

Steps to reproduce the behavior:

  1. Open Deck app on smartphone.
  2. Click on any card that already has tags to open it for editing.
  3. Click on the tag dropdown for adding tags.
  4. It shows only tags that are not yet added to the card. (which is good)
  5. Remove one of the tags that is already present on the card.
  6. Click on the tag dropdown for adding tags again.
  7. The dropdown shows the identical collection of tags compared to the first time. The removed one is missing. (Bad)

Expected behavior

Tags which have been removed while editing the card should show up in the add-tag-dropdown right after they've been removed, so they can be readded in the same edit activity, without discarding or saving the cards once in between an reopening the card editor again.

Screenshots

-none-

Versions

Smartphone (please complete the following information):

Are you using LDAP?

Stacktrace -none-

desperateCoder commented 3 years ago

Hi @mrbenjoi, wow, very good catch! And very nice detailed explanation, we'll have a look at it!

@stefan-niedermann I haven't any chance to include the deleted one, because it is deleted at save. I guess you'll need to handle this on the UI...