Saved windows do not restore

[Reselka]

Clicking the green check mark on a saved window to restore it instead opens a new window with only two tabs: a new tab and the first tab from the saved window. The original saved window remains in the saved window section and does not become active.

[RobbyTheBelgian]

Same here, Google Chrome Version 87.0.4280.66 (Official Build) (64-bit) on Ubuntu 18.04.5 LTS.

[mastef]

Could you kindly attach a .json file here so I could reproduce? You can remove any personal info from it ( urls and tab titles ) - just make sure that the changed file also produces the same bug for you.

Have you also tried restoring the session when the tab manager is open in its' own tab?

[RobbyTheBelgian]

Running it in its own tab seems to work fine.

This is an example that does not work when using the icon but does work when running TM+ in its own tab:

[
  {
    "date": 1606277389487,
    "id": "6e1acf7d-8570-4f0a-a9ee-4c930e4a962c",
    "name": "wikipedia, google",
    "sessionStartTime": 1606277389487,
    "tabs": [
      {
        "active": false,
        "audible": false,
        "autoDiscardable": true,
        "discarded": false,
        "favIconUrl": "https://www.wikipedia.org/static/favicon/wikipedia.ico",
        "height": 765,
        "highlighted": false,
        "id": null,
        "incognito": false,
        "index": 0,
        "mutedInfo": {
          "muted": false
        },
        "pinned": false,
        "selected": false,
        "status": "complete",
        "title": "Wikipedia",
        "url": "https://www.wikipedia.org/",
        "width": 1536,
        "windowId": 685
      },
      {
        "active": true,
        "audible": false,
        "autoDiscardable": true,
        "discarded": false,
        "favIconUrl": "https://www.google.com/favicon.ico",
        "height": 765,
        "highlighted": true,
        "id": null,
        "incognito": false,
        "index": 1,
        "mutedInfo": {
          "muted": false
        },
        "openerTabId": 686,
        "pinned": false,
        "selected": true,
        "status": "loading",
        "title": "stackoverflow.com",
        "url": "https://stackoverflow.com",
        "width": 1536,
        "windowId": 685
      }
    ],
    "windowsInfo": {
      "alwaysOnTop": false,
      "focused": true,
      "height": 837,
      "id": 685,
      "incognito": false,
      "left": 720,
      "state": "maximized",
      "top": 27,
      "type": "normal",
      "width": 1536
    }
  }
]

On Tue, Nov 24, 2020 at 7:43 PM Markus notifications@github.com wrote:

Could you kindly attach a .json file here so I could reproduce? You can remove any personal info from it ( urls and tab titles ) - just make sure that the changed file also produces the same bug for you.

Have you also tried restoring the session when the tab manager is open in its' own tab?

[image: image] https://user-images.githubusercontent.com/762297/100180555-f9ad6180-2f0a-11eb-879b-3de1206ec605.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stefanXO/Tab-Manager-Plus/issues/133#issuecomment-733443958, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4ZMSD5ZK22DLZO4UOHVE3SRR4NHANCNFSM4R43G6MQ .

[crutley]

I'm trying this extension for the first time and seeing the same thing. Restoring a saved window works from the sidebar or dedicated tab, but fails to restore most of the tabs when using the function from the pop-up window.

That said, I know it's an experimental feature.

A nice feature to add to window restoring would be the ability to lazy load all the tabs.

[nybbles]

I'm experiencing the same issue on Firefox

[mastef]

Moved to #179