search

stefanXO / Tab-Manager-Plus

An updated and improved Chrome and Firefox extension of the old google chrome extension "Tab Manager".
Other
382 stars 91 forks source link

Ignore window if it's just the tab manager in one tab #174

Open cormacrelf opened 2 years ago

Penguin-Guru commented 2 years ago

Assuming this works, it seems like a nice improvement. Is it convenient to also ignore windows with only empty tabs? I think it might actually be a good idea to ignore empty tabs even in windows that won't be ignored, but that's probably a different feature for a different PR. Just some ideas.

mastef commented 2 years ago

First of all - thank you for helping by submitting a PR.

I'm a bit concerned about the functionality though - how do I get back to the window that has the tab manager ( e.g. from a popup ) 🤔 Maybe we should simply move this window to the end of the list, instead of hiding it?

Or create a separate section like "Minimized windows" - called "Other". But then we'll lose simplicity.

cormacrelf commented 2 years ago

Oh, is there a way to check the identity of the current tab and compare it? That would allow hiding it from only the one through which it is viewed.

cormacrelf commented 2 years ago

Basically this is all an A/B problem where what I actually want is a floating window that doesn't get hidden from view when other windows are activated. (Especially since clicking anywhere in a single-tab-window tab manager switches to another window.) I don't think you can do that though, hence this.

mastef commented 2 years ago

Oh, is there a way to check the identity of the current tab and compare it? That would allow hiding it from only the one through which it is viewed.

We know if we're in a popup, or own window by checking window.inPopup.

If we're in own window, we can check await browser.tabs.getCurrent() which should be our tab.

And then we can work from there 🤔

Did you mean that?