search

stefanXO / Tab-Manager-Plus

An updated and improved Chrome and Firefox extension of the old google chrome extension "Tab Manager".
Other
398 stars 104 forks source link

Windows won't restore #217

Closed oscarrob754 closed 2 months ago

oscarrob754 commented 1 year ago

I'm on a hotel network away from home and all of a sudden windows won't restore. They save. The tabs are labled but when I try to restore I get nothing.

mastef commented 1 year ago

Try opening the tab manager in its' own tab

oscarrob754 commented 1 year ago

Tried that. It didn’t work.

On Tue, Aug 1, 2023 at 3:22 PM mastef @.***> wrote:

Try opening the tab manager in its' own tab

— Reply to this email directly, view it on GitHub https://github.com/stefanXO/Tab-Manager-Plus/issues/217#issuecomment-1661118781, or unsubscribe https://github.com/notifications/unsubscribe-auth/A35FKQLJWTE5XRTFKUPBKO3XTFXSRANCNFSM6AAAAAA3ABGYWI . You are receiving this because you authored the thread.Message ID: @.***>

-- JR

Jonathan Robertson Newport Beach, CA @.***

"Never get angry. Never make a threat. Reason with people." Don Vito Corleone, 'The Godfather', Mario Puzo US novelist & screenwriter (1920 - 1999)

“Quia ursus pusilli ingenii sum verbs difficilia fastidio”

mastef commented 1 year ago

Then I think it's trying to restore the windows to a monitor position that doesn't exist anymore - e.g. if at home/office you have a monitor connected and now you don't.

I also just ran into that.

Seems like a more recent change that windows that are being created by extensions have to cover at least 50% of the screen.

oscarrob754 commented 1 year ago

That's probably it since I'm currently in a hotel on my laptop and my home monitor is a widescreen. Any solution?

oscarrob754 commented 1 year ago

PS - in chrome on a Macbook M1x at home its connected to a Samsung wide screen

mastef commented 1 year ago

So I found one quick way :

  1. In the options menu - export your sessions image
  2. Open that .json file with some text editor like notepad
  3. Search for any mentions of "top" and "left" that have a negative value : image
  4. Change them to 0 image
  5. Save the file
  6. In the options import it again through "restore sessions" image
oscarrob754 commented 1 year ago

Thanks, I'll check it out. JR

Jonathan Robertson Newport Beach, CA @.***

"Never get angry. Never make a threat. Reason with people." Don Vito Corleone, 'The Godfather', Mario Puzo US novelist & screenwriter (1920 - 1999)

“Quia ursus pusilli ingenii sum verbs difficilia fastidio”

On Tue, Aug 1, 2023 at 10:07 PM mastef @.***> wrote:

So I found one quick way :

  1. In the options menu - export your sessions [image: image] https://user-images.githubusercontent.com/762297/257707013-30cf4bc4-1dcc-4d2b-bcde-e2f7665925aa.png
  2. Open that .json file with some text editor like notepad
  3. Search for any mentions of "top" and "left" that have a negative value : [image: image] https://user-images.githubusercontent.com/762297/257707208-aa411898-e356-4dc2-8ac2-3c2dafdf3bf5.png
  4. Change them to 0 [image: image] https://user-images.githubusercontent.com/762297/257707285-841616db-b116-426a-abeb-66d4162bf0cb.png
  5. Save the file
  6. In the options import it again through "restore sessions" [image: image] https://user-images.githubusercontent.com/762297/257707361-f6840158-28b8-4e5a-a239-27ceeba21f27.png

— Reply to this email directly, view it on GitHub https://github.com/stefanXO/Tab-Manager-Plus/issues/217#issuecomment-1661502813, or unsubscribe https://github.com/notifications/unsubscribe-auth/A35FKQJAAANN255P7O6JPD3XTHOB3ANCNFSM6AAAAAA3ABGYWI . You are receiving this because you authored the thread.Message ID: @.***>

Andresnotch commented 1 year ago

Got the same problem but I didn't have any negative numbers. In my case I reset all the positions to 0 and it worked!

MrWaaat commented 1 year ago

Also ran into the same problem. Changed all "top" and "left" in the json file and imported it again and it worked. Why not implement a radio button where you can choose if you want to save the window positions or not and maybe put store window position as Beta? If you choose not to store the window positions all "top" and "left" are put to zero in Tab Manager. Just a suggestion to get around the problem "easy".

AntonBogun commented 11 months ago

This happens constantly in multi-screen configurations, so it would probably be smart to actually fix the code to just min() the size with the size of the screen so that it doesn't completely refuse to open the window but just makes the window smaller. Could this be fixed?

mastef commented 2 months ago

Should be fixed in next version based on a65574d7a25799444a457a4bdb936e4a940a3ba0