search

stefanbesler / twingrind

Call-graph profiling for TwinCAT 3
GNU General Public License v3.0
24 stars 3 forks source link

feat: added an argument for an optional symbol prefix, which is needed if TC_SYM_WITH_NAMESPACE is used when compiling the PLC #7

Closed stefanbesler closed 1 year ago

stefanbesler commented 1 year ago

this MR closes #5

stefanbesler commented 1 year ago

i wont use join to concate the prefix and "Profiler" because it adds an sperater (if i am wrong i am sorry im not python pro). is something like this possible: profiler_symbolname = {symbol_prefix}"Profiler"

keep in mind if no prefix is given no dot has to be added bevor "Profiler".

also please make an log entry for profiler_symbolname and parameterlist_symbolname

thx

parameterlist_symbolname = "."join(symbol_prefix, "ParameterList")

This is not yet tested or even remotely finished. For specfic changes I recommend you to create your own pull request

Commanding stuff like "also please make an log entry for profiler_symbolname and parameterlist_symbolname" is not they way to go with an open source project, btw

stefanbesler commented 1 year ago

Implemented in a different branch