search

stefanbirkner / system-rules

A collection of JUnit rules for testing code which uses java.lang.System.
http://stefanbirkner.github.io/system-rules
Other
546 stars 71 forks source link

Java 9 compatibility? #52

Closed szpak closed 6 years ago

szpak commented 6 years ago

I use the system-rules in some framework dependent projects to test "untestable" things. As Java 9 is approaching quickly I was wondering if system-rules can be used with it, especially that there is a lot of "hack" used to do the things.

I wanted to give it a try, but it seems there are some Maven plugins required to be upgraded (probably the same as some libraries) I decided to just create that issue to consider checking that compatibility one sunny day.

stefanbirkner commented 6 years ago

I built System Rules with Java 9 and it was successful (all tests are green): https://travis-ci.org/stefanbirkner/system-rules/builds/279670791 Next step is to enable JDK9 on Travis.

szpak commented 6 years ago

Great to hear!

Btw, did you mean "AppVeyor" instead of "Travis"? In the aforementioned link there is already a Travis build with Java 9.

stefanbirkner commented 6 years ago

No, I mean Travis. The branch under test has three commits and you only see the last one. Here is the diff of the branch: https://github.com/stefanbirkner/system-rules/compare/java9

stefanbirkner commented 6 years ago

Fixed by 2361ee6675e549001b9364d1a6cdea21e047bc24