search

stefanbode / Sonoff-Tasmota

Provide ESP8266 based itead Sonoff with Web, MQTT and OTA firmware using Arduino IDE, enhanced with I2C options
GNU General Public License v3.0
126 stars 40 forks source link

MCP23008/MCP23017 Support #42

Closed andrethomas closed 6 years ago

andrethomas commented 6 years ago

Hi

Are you planning on adding support for MCP23008/MCP23017 to this?

Thanks

stefanbode commented 6 years ago

Hi, I took a small look on this chip and for me it looks like there is no big deal to support this similar to the PCF one. I still have the open task to support also the digital input use-case. Do you really need this? If yes I would order some chips to get them tested.

andrethomas commented 6 years ago

It's not urgent - I have the chips and can probably use your pcf code as a template to add support for the MCP once you're done with handling the input side.

stefanbode commented 6 years ago

Because the devices nearly do the same it could be much more straight forward to integrate instead of duplicate the code. I will order some devices and work on the input side. I have still the requirements to detect the valve end position.

stefanbode commented 6 years ago

I have seen you pull request at the original code. As soon as my hardware arrives I will give it a try we’ll done and interesting chipset.

andrethomas commented 6 years ago

Cool, I found the MCP's to be more useful for inputs than the PCF's most specifically because of the interrupt polling that may be implemented through I2C whereas the PCF-8574 relies on using an external interrupt pin which will in some way need to be connected to the ESP8266 and I cannot see that happening in the main build for now since most of the Sonoff devices have limited input pins.

Either way, the interrupts are a cool way of triggering MQTT messages which I found useful for my application :)

andrethomas commented 6 years ago

Doesn't look like its gonna get committed into the main development - Guess I'll have to do what you're doing... just a pain to keep the fork updated all the time though.. which method do you use?

stefanbode commented 6 years ago

I can offer you to integrate this into my branch, then you don't have the additional effort. But I have to take a look into it first. My hardware still not arrived for testing.

Merging is a pain. That's the reason why I tag all my changes with //STB MOD //END. This makes is simple for me to check if I just merge the main branch or have to take a closer look at how the changes affect me. Anyhow it is still quite work. Especially when something general changes.

I do the merge with "beyond compare" simple easy and I still own a license. :-)

andrethomas commented 6 years ago

beyond compare looks pretty cool for $60

andrethomas commented 6 years ago

MCP23008/MCP23017 for input was merged to arendst:development

stefanbode commented 6 years ago

This is good news. As soon as arend enabled something inter master like the HR04 I remove it immediate from my branch. Want to keep the differences as minimal as possible. It should be a mod of the original firmware and not a competitive side development.