search

stefanbohacek / detect-missing-adblocker

Remind your website’s visitors to stay safe in the wilderness of the world wide web.
https://wordpress.org/plugins/detect-missing-adblocker/
GNU General Public License v3.0
49 stars 4 forks source link

Does not detect Privacy Badger #16

Open seefood opened 10 months ago

seefood commented 10 months ago

https://privacybadger.org/

stefanbohacek commented 10 months ago

Thank you for opening the issue, I will look into it!

seefood commented 8 months ago

Well, this is starting to annoy my readers, I'm forced to turn off the plugin for now...

stefanbohacek commented 8 months ago

@seefood Very sorry about that, and thank you for reporting this.

iam-py-test commented 8 months ago

Respectfully, in my opinion, Privacy Badger isn't an adblocker. It has many of the benefits (blocking tracking, and some ads), but doesn't do everything an adblocker would (for example, it doesn't block Google Search Ads - which are a common vector for malware). Maybe there could be an option to change the strictness (Only adblockers, include tracker blocking extensions) and maybe the message could inform users they are partly protected. Thanks

seefood commented 8 months ago

Respectfully, in my opinion, Privacy Badger isn't an adblocker.

Regardless, people do use it as an ad blocker, and quite effectively I would add, such as myself and some of the readers on my blog, and we still get the popup. Putting aside the "official" intention of the product it's what it is used for that really matters here.

stefanbohacek commented 8 months ago

I see where @iam-py-test is coming from, but I do have to agree with @seefood. If Privacy Badger does block some ads, the expectation will be not to see the note to install an ad-blocker.

I am a bit tied up with other things at the moment, but this project is still very much on my radar and I will continue looking for a solution.

I appreciate everyone's patience.

fullStackRacc commented 3 months ago

Hi, I'm trying to look into closing some of these issues to help, and I was looking through to see what privacy badger sees as an ad, and it is solely a tracking blocker (if it happens to block an ad, it's simply because the ad was tracking you) as per their website.

"As a result, Privacy Badger differs from traditional ad-blocking extensions in two key ways. First, while most other blocking extensions prioritize blocking ads, Privacy Badger is purely a tracker-blocker. The extension doesn’t block ads unless they happen to be tracking you; in fact, one of our goals is to incentivize advertisers to adopt better privacy practices."

it seems like the only way to trigger privacy badger in general (because it's not an ad-blocker, its a tracker blocker) is to add a tracker to the code (and assume they will have it on file) which seems antithetical to the goal of the plugin, unless there's a way to find what they qualify as a tracker and put in something that can trigger the plugin without actually tracking the user.

EDIT: yeah, you would need to trigger some things as below

"At a more technical level, Privacy Badger keeps note of the “third party” domains that embed images, scripts and advertising in the pages you visit. Privacy Badger looks for tracking techniques like uniquely identifying cookies, local storage “supercookies,” and canvas fingerprinting. If it observes a single third-party host tracking you on three separate sites, Privacy Badger will automatically disallow content from that third-party tracker."

iam-py-test commented 3 months ago

If it observes a single third-party host tracking you on three separate sites, Privacy Badger will automatically disallow content from that third-party tracker.

That is no longer the case. Now it uses automatically-generated but prebuilt rules. One could pick a domain which Privacy Badger blocks and try to connect to it, but this is not a flawless approach and would expose users IP/headers to a tracking domain. Thanks

stefanbohacek commented 3 months ago

Thank you both for looking into this, I really appreciate it!

Yeah, this one is a bit tricky. Good point about exposing the site visitor's IP. Let me keep this ticket open while I think about this some more.