search

stefandoorn / sitemap-plugin

Sitemap Plugin for Sylius eCommerce platform
MIT License
79 stars 44 forks source link

2.1.0 is not compatible with php 7.4 #245

Closed t-n-y closed 1 year ago

t-n-y commented 1 year ago

Hi,

The 2.1.0 release is supposed to be compatible with php 7.4, but SitemapController.php construct use a comma at the end of the parameters so that doesn't work under php8

stefandoorn commented 1 year ago

Ah :-( Will look into that soon and tag accordingly. Obviously open to PR's as well for it to add PHP 7.4 support again. Probably something needs to change in the ECS settings to allow this.

stefandoorn commented 1 year ago

I think it's fixed by this release: https://github.com/stefandoorn/sitemap-plugin/releases/tag/v2.1.1

Could you let me know?

t-n-y commented 1 year ago

Seems ok, thanks !