search

stefandoorn / sitemap-plugin

Sitemap Plugin for Sylius eCommerce platform
MIT License
79 stars 45 forks source link

Update composer.json #254

Closed SquareInnov closed 7 months ago

SquareInnov commented 7 months ago

Allow next major Sylius version 1.13

stefandoorn commented 7 months ago

Thanks, @SquareInnov - can you also change it in the test set-up so we ensure the tests also run against Sylius 1.13?

https://github.com/stefandoorn/sitemap-plugin/blob/master/.github/workflows/build.yml

stefandoorn commented 7 months ago

Not really sure though why CI does not run.. :D

SquareInnov commented 7 months ago

Done, Regarding to this : https://github.com/Sylius/Sylius/blob/1.13/UPGRADE-1.13.md

I bump php version and add new symfony version to the file

SquareInnov commented 7 months ago

Not really sure though why CI does not run.. :D

I don't know, the branch is not excluded

stefandoorn commented 7 months ago

I have enabled Builds/CI again. Will check / test the PR later this week. Does it already work with the beta of 1.13 as well with this change, or won't this be in effect anyhow until 1.13 is officially released?

SquareInnov commented 7 months ago

I have enabled Builds/CI again. Will check / test the PR later this week. Does it already work with the beta of 1.13 as well with this change, or won't this be in effect anyhow until 1.13 is officially released?

No, it will work on the the release of the 1.13, I think.

stefandoorn commented 7 months ago

Merging this and if something pops up in CI, I'll look into that. Thanks!