search

stefandoorn / sitemap-plugin

Sitemap Plugin for Sylius eCommerce platform
MIT License
79 stars 44 forks source link

Pass parameter to static route #34

Closed czende closed 6 years ago

czende commented 6 years ago

Hi, I'm using bitbag CMS plugin and just want to pass slug parameter to the static route bitbag_sylius_cms_plugin_shop_page_show in your plugin. But still get "unrecognized option slug". Any hint how to properly pass slug to bitbag cms route in yml sitemap config?

Thank you!

stefandoorn commented 6 years ago

Hi, probably best is to make a BitBagCmsProvider to have full support for all CMS routes dynamic. I still have it on my todo list, but didn't have time yet. It should be stored in a separate plugin as a bridge imo. If you have interest in developing one, that would be great of course :)

Anyway, short term: did you try the parameters key that can be supplied to a static route? That one should be able to take an array including the slug key.

If it doesn't work, please copy also your config so I can have a better look.

stefandoorn commented 6 years ago

@czende Any tests results as suggested? I still need to look into it :(

czende commented 6 years ago

@stefandoorn Sorry, I've been busy. Yes, I tried pass the parameters key to a static route, but I'm still getting error Unrecognized option "slug" under "sylius_sitemap.static_routes.1.parameters.0"

Maybe @bitbager can help us?

bitbager commented 6 years ago

Sorry to say that, but I'm not the author 😢

stefandoorn commented 6 years ago

:-) Ok. I will try to look into it. If you have some time @czende, some failing test would already help (or a PR with a fix of course).

Next on the roadmap is to provide integration with CmsPlugin that is developed by @bitbager, but yeah.. need a bit more time to work on that :)