[ProductDetailImpressionDataResolver] Avoid listing disabled product variant or having no price

stefandoorn / sylius-google-tag-manager-enhanced-ecommerce-plugin

Enhanced Ecommerce implementation through Google Tag Manager for Sylius eCommerce Platform

MIT License

35 stars 19 forks source link

[ProductDetailImpressionDataResolver] Avoid listing disabled product variant or having no price #111

Closed Prometee closed 3 years ago

Prometee commented 3 years ago

Hello @stefandoorn ,

I found a bug while playing around with a disabled product variant, it seems that the ProductDetailImpressionDataResolver is not using any filter to get all product variants. I don't know yet how Sylius is filtering those variant on a product page, but I think filtering the variants here could help, I will investigate this issue tomorrow 😉.