search

stefandoorn / sylius-google-tag-manager-enhanced-ecommerce-plugin

Enhanced Ecommerce implementation through Google Tag Manager for Sylius eCommerce Platform
MIT License
36 stars 20 forks source link

Session Service Deprecation in Symfony 5.3 and removal in 6 #167

Closed olia-bn closed 1 year ago

olia-bn commented 1 year ago

SessionInterface got deprecated in 5.3 and removed as public service in 6

RequestStack shoudl be used instead

https://symfony.com/blog/new-in-symfony-5-3-session-service-deprecation

stefandoorn commented 1 year ago

Hi @olia-bn - would you be able to submit a PR with a proposed change to support this deprecation?

Prometee commented 1 year ago

166 is fixing this issue.

stefandoorn commented 1 year ago

I will have a look at it next week :)

stefandoorn commented 1 year ago

Oh, already merged haha.