search

stefanedwards / lemon

🍋 Lemon --- Freshing up your ggplots
https://cran.r-project.org/package=lemon
GNU General Public License v3.0
180 stars 11 forks source link

update `panel_guides_grob()` #33

Closed teunbrand closed 5 months ago

teunbrand commented 6 months ago

Hi Stefan,

This is a follow-up on #30. We have been preparing a new release of ggplot2 and during a reverse dependency check it became apparent that the prospective ggplot2 3.5.0 would break lemon. As the person responsible for the breakage, I thought I might help out with a PR.

Since implementing #30 we have slightly changed the mechanism in panel_guides_grob(). This PR reflects these changes in the one used by lemon. To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled at the end of January / early Februari. The progress can be tracked in https://github.com/tidyverse/ggplot2/issues/5588.

teunbrand commented 5 months ago

This is just a friendly reminder that the release of ggplot2 is scheduled soon.

stefanedwards commented 5 months ago

I am working on it, as we are speaking (so to say).

Den ons. 7. feb. 2024 kl. 11.30 skrev Teun van den Brand < @.***>:

This is just a friendly reminder that the release of ggplot2 is scheduled soon.

— Reply to this email directly, view it on GitHub https://github.com/stefanedwards/lemon/pull/33#issuecomment-1931745152, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3NBGUBXCE55FJLMEBCJA3YSNJSNAVCNFSM6AAAAABBSYLCP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZRG42DKMJVGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

teunbrand commented 5 months ago

Great thanks!