search

stefanfoulis / django-phonenumber-field

A django model and form field for normalised phone numbers using python-phonenumbers
MIT License
1.49k stars 315 forks source link

Allow multiple DRF is_valid calls to succeed #543

Closed phillipuniverse closed 1 year ago

phillipuniverse commented 1 year ago

Fixes #542

phillipuniverse commented 1 year ago

Happy to go through the process of adding tests, etc but I wanted to make sure this is a reasonable change!

francoisfreitag commented 1 year ago

As noted in the issue, the change is reasonable and fixing a bug in the library (when comparing to DRF builtin serializer fields. Thank you for reporting (and fixing!) it. Feel free to add a test. When the PR is ready, I’ll merge your work and make a release.

phillipuniverse commented 1 year ago

@francoisfreitag test added and missing import fixed!

francoisfreitag commented 1 year ago

Great, thank you!