search

stefanfoulis / django-phonenumber-field

A django model and form field for normalised phone numbers using python-phonenumbers
MIT License
1.49k stars 315 forks source link

Italian translations incomplete #569

Closed RuggeroFabbiano closed 10 months ago

RuggeroFabbiano commented 1 year ago

Hello

There are a couple of translations missing in the Italian locale, that make the form error message appear in the default language when a wrong telephone number is submitted.

Happy to contribute if needed.

francoisfreitag commented 1 year ago

Yes please! You should be able to edit https://github.com/stefanfoulis/django-phonenumber-field/blob/main/phonenumber_field/locale/it/LC_MESSAGES/django.po on GitHub. The msgid is the original version of the string, and msgstr is the corresponding translation.

If you’re not confortable generating the .mo file, no worries, I’ll do it on the PR (be sure to allow edits from maintainers).

Thanks in advance :star:

francoisfreitag commented 1 year ago

(note that strings marked as fuzzy could use an update as well)

RuggeroFabbiano commented 10 months ago

Sorry for the late reply, have been quite busy 😅 No worries, I'm quite used to how it works. I should be able to do it soon!

RuggeroFabbiano commented 10 months ago

I generated the .mo file, but I wasn't able to commit it due to them be Git-ignored.

francoisfreitag commented 10 months ago

Yes, I changed the release process to generate the MO files, so that git only follows the .po from now on. I didn’t think to come back to this PR.

Corresponding PR: https://github.com/stefanfoulis/django-phonenumber-field/pull/590